Document CT changes for v11 #4828
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| version 11.0. | ||
| [See the full changelog for version 10.0](/guides/references/changelog#11-0-0). | ||
|
|
||
| ### Component Testing Changes |
There was a problem hiding this comment.
This is the second Component Testing Changes section within this page, which causes the latter to be incremented to make it unique e.g. https://cypress-documentation-gdkinysy2-cypress-io.vercel.app/guides/references/migration-guide#Component-Testing-Changes-1
Doesn't look like we have an on-link attached to this and seems like an edge-case, just wanted to point it out
There was a problem hiding this comment.
I noticed this as well, I changed it to "Component Testing Updates" to make it unique and pushed a corresponding commit to your services PR.
Co-authored-by: Stokes Player <[email protected]>
…ss-io/cypress-documentation into release-11-migration-guide
We never had |
| ### Component Testing Updates | ||
|
|
||
| As of Cypress 11, Component Testing is now generally available. Learn more about | ||
| what generally available implies [here](link_to_post) and the improvements |
There was a problem hiding this comment.
whats the generally available post?
There was a problem hiding this comment.
I thought were we going to post a definition of GA but looks like we aren't doing that anymore (at least before GA).
Removed.
| #### After - Cypress 11 and `unmountComponentAtNode` | ||
|
|
||
| ```js | ||
| import { getContainerEl } from 'cypress/react' |
There was a problem hiding this comment.
is getContainerEl new? It doesn't appear to be in v10. Why wouldn't they just use the component that the mount returns?
There was a problem hiding this comment.
It actually is in v10, it's from cypress/mount-utils. https://github.com/cypress-io/cypress/blob/develop/npm/mount-utils/src/index.ts#L42. It isn't documented but it how we write and ensure all our mount adapters target the same element.
You can't unmount a component, you need to pass the exact same HTML element you mounted on (this is how React works). It's the argument called container here: https://reactjs.org/docs/react-dom.html#unmountcomponentatnode.
I personally think just keeping umount would have been far more ergonomic, but this shouldn't be too disruptive - unmount isn't that commonly used, from what I can see.
There was a problem hiding this comment.
we should add some tsdocs around getContainerEl since its a part of our api now
|
Links are all updated. I think this is ready to merge. |
|
Updated, thanks @astone123 |
Short version of the CT changes in Cypress 11. A more detailed article will be posted that explains out rationale and provides some additional insights: https://docs.google.com/document/d/1n4H0ADl0QNBWqbtGiKg4AzC0v8pQ8wZL0YLZeOCOg94/edit# (Cypress team only for now, until published).