Skip to content

Conversation

@petricm
Copy link
Collaborator

@petricm petricm commented Dec 16, 2020

  • This extends the the action to work on macOS with the limitions to mount the repository under /User/share
  • Maps all variables from Client Parameters to same name github action parameters
  • All default paramers are in the action and none in the scripts
  • The default.local how by default only CVMFS_CLIENT_PROFILE='signle' and CVMFS_USE_CDN='yes' as CVMFS_HTTP_PROXY is implied by CVMFS_USE_CDN

I am still having problem to configure that the testing would work for PRs but

- uses: cvmfs-contrib/github-action-cvmfs@main
+ uses: ${{ github.repository }}@main

But does not want. So there is a bit of work here still

@petricm petricm requested a review from vvolkl December 16, 2020 15:26
@wdconinc
Copy link
Collaborator

I would keep at least one instance of the work 'cvmfs' in the name or description in action.yml. Searches for actions on the github marketplace will likely be based on that search term.

Copy link
Collaborator

@vvolkl vvolkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small readme typo, otherwise looks good to me!

@petricm
Copy link
Collaborator Author

petricm commented Dec 16, 2020

I am still working on testing... give me a bit

@petricm
Copy link
Collaborator Author

petricm commented Dec 16, 2020

OK, have reconfigured the tests so that they run a local checkout of the code instead of the code from the main repo. But this still needs to be merged first before this will take into effect. I might have overlooked something, but I think it will be easier to spot once merged.

@wdconinc wdconinc merged commit 2ef36bf into cvmfs-contrib:main Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants