Skip to content

Show Example Fix for Infinite UseEffect Loop #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Show Example Fix for Infinite UseEffect Loop #247

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion apps/frontend/src/lib/garden/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { sha256 } from "js-sha256";

export const flowerSize = (size: number): string => {
console.log(size);
if (size > 200) {
return "large";
} else if (size > 100) {
Expand Down
10 changes: 8 additions & 2 deletions apps/frontend/src/pages/people/[username].tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,13 +204,16 @@ const UserProfilePage: React.FC = () => {
const [chipId, setChipId] = useState("");
const { socket } = useSocket();


// useEffect gates
const [ fetchedChipId, setFetchedChipId] = useState(false);

useEffect(() => {
const fetchChipIp = async () => {
const user = await storage.getUser();
const session = await storage.getSession();
const unregisteredUser = await storage.getUnregisteredUser();
if (user && session && !unregisteredUser) {
console.log('pre admin', user.userData)
if (user && connection?.user?.username && (
user.userData.username === "stevenelleman" ||
user.userData.username === "andrew" ||
Expand All @@ -222,7 +225,10 @@ const UserProfilePage: React.FC = () => {
}
}
}
fetchChipIp();
if (!fetchedChipId) {
fetchChipIp();
setFetchedChipId(true);
}
});

useEffect(() => {
Expand Down