Add support to autoformat a gherking file #553
Conversation
| version: ${version_cleanup;${mvnVersion}} | ||
| Bundle-SymbolicName: ${mvnGroupId}.${mvnArtifactId} | ||
| Bundle-Version: ${version} | ||
| Import-Package: !sun.*,io.cucumber.messages.internal.com.google.gson*,!io.cucumber.messages.internal.*,!org.checkerframework.*,* |
There was a problem hiding this comment.
I don't think cucumber.messages.internal still exists.
There was a problem hiding this comment.
@mpkorstanje year this is maybe not required anymore and is a bit cumbersome to manage anyways. Because of that I would suggest adding the data in cucumber directly as with:
this is much more appropriate and consistent.
There was a problem hiding this comment.
The problem with these definitions is that it they're equally cumbersome if kept with the project itself. Problems exclusively show up at runtime. In this case it is harmless, but forgetting to expose a package would break that module.
But lets keep that discussion in github.com/cucumber/gherkin-utils/pull/131. Consider this FYI.
There was a problem hiding this comment.
@mpkorstanje in this case superfluous instructions simply do not taken into account but of course to not add to the clarity. So we can see this more as no one ever noticed this has gone :-D
2 participants
Fix #544
Fix #478