Skip to content

Commit 4c634b6

Browse files
qianfengrongherbertx
authored andcommitted
crypto: qat - use kcalloc() in qat_uclo_map_objs_from_mof()
As noted in the kernel documentation [1], open-coded multiplication in allocator arguments is discouraged because it can lead to integer overflow. Use kcalloc() to gain built-in overflow protection, making memory allocation safer when calculating allocation size compared to explicit multiplication. Similarly, use size_add() instead of explicit addition for 'uobj_chunk_num + sobj_chunk_num'. Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments #1 Signed-off-by: Qianfeng Rong <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> Acked-by: Giovanni Cabiddu <[email protected]> Signed-off-by: Herbert Xu <[email protected]>
1 parent dcd2d5f commit 4c634b6

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/crypto/intel/qat/qat_common/qat_uclo.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1900,7 +1900,7 @@ static int qat_uclo_map_objs_from_mof(struct icp_qat_mof_handle *mobj_handle)
19001900
if (sobj_hdr)
19011901
sobj_chunk_num = sobj_hdr->num_chunks;
19021902

1903-
mobj_hdr = kzalloc((uobj_chunk_num + sobj_chunk_num) *
1903+
mobj_hdr = kcalloc(size_add(uobj_chunk_num, sobj_chunk_num),
19041904
sizeof(*mobj_hdr), GFP_KERNEL);
19051905
if (!mobj_hdr)
19061906
return -ENOMEM;

0 commit comments

Comments
 (0)