Skip to content

Commit 3dc8d7f

Browse files
committed
Merge branch 'kvm-updates/2.6.36' of git://git.kernel.org/pub/scm/virt/kvm/kvm
* 'kvm-updates/2.6.36' of git://git.kernel.org/pub/scm/virt/kvm/kvm: KVM: PIT: free irq source id in handling error path KVM: destroy workqueue on kvm_create_pit() failures KVM: fix poison overwritten caused by using wrong xstate size
2 parents 4238a41 + 6b5d7a9 commit 3dc8d7f

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

arch/x86/kernel/i387.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@
4040

4141
static unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
4242
unsigned int xstate_size;
43+
EXPORT_SYMBOL_GPL(xstate_size);
4344
unsigned int sig_xstate_ia32_size = sizeof(struct _fpstate_ia32);
4445
static struct i387_fxsave_struct fx_scratch __cpuinitdata;
4546

arch/x86/kvm/i8254.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -697,6 +697,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
697697
pit->wq = create_singlethread_workqueue("kvm-pit-wq");
698698
if (!pit->wq) {
699699
mutex_unlock(&pit->pit_state.lock);
700+
kvm_free_irq_source_id(kvm, pit->irq_source_id);
700701
kfree(pit);
701702
return NULL;
702703
}
@@ -742,7 +743,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
742743
kvm_unregister_irq_mask_notifier(kvm, 0, &pit->mask_notifier);
743744
kvm_unregister_irq_ack_notifier(kvm, &pit_state->irq_ack_notifier);
744745
kvm_free_irq_source_id(kvm, pit->irq_source_id);
745-
746+
destroy_workqueue(pit->wq);
746747
kfree(pit);
747748
return NULL;
748749
}

arch/x86/kvm/x86.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2387,7 +2387,7 @@ static void kvm_vcpu_ioctl_x86_get_xsave(struct kvm_vcpu *vcpu,
23872387
if (cpu_has_xsave)
23882388
memcpy(guest_xsave->region,
23892389
&vcpu->arch.guest_fpu.state->xsave,
2390-
sizeof(struct xsave_struct));
2390+
xstate_size);
23912391
else {
23922392
memcpy(guest_xsave->region,
23932393
&vcpu->arch.guest_fpu.state->fxsave,
@@ -2405,7 +2405,7 @@ static int kvm_vcpu_ioctl_x86_set_xsave(struct kvm_vcpu *vcpu,
24052405

24062406
if (cpu_has_xsave)
24072407
memcpy(&vcpu->arch.guest_fpu.state->xsave,
2408-
guest_xsave->region, sizeof(struct xsave_struct));
2408+
guest_xsave->region, xstate_size);
24092409
else {
24102410
if (xstate_bv & ~XSTATE_FPSSE)
24112411
return -EINVAL;

0 commit comments

Comments
 (0)