KVM: PIT: free irq source id in handling error path

Xiao Guangrong · avikivity · commit 6b5d7a9f6f7f · 2010-08-17T12:04:23.000+03:00
Free irq source id if create pit workqueue fail

Signed-off-by: Xiao Guangrong &lt;xiaoguangrong@cn.fujitsu.com&gt;
Signed-off-by: Avi Kivity &lt;avi@redhat.com&gt;
diff --git a/arch/x86/kvm/i8254.c b/arch/x86/kvm/i8254.c
@@ -697,6 +697,7 @@ struct kvm_pit *kvm_create_pit(struct kvm *kvm, u32 flags)
 	pit->wq = create_singlethread_workqueue("kvm-pit-wq");
 	if (!pit->wq) {
 		mutex_unlock(&pit->pit_state.lock);
+		kvm_free_irq_source_id(kvm, pit->irq_source_id);
 		kfree(pit);
 		return NULL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -697,6 +697,7 @@ struct kvm_pit kvm_create_pit(struct kvm kvm, u32 flags)`
`697`	`697`	`pit->wq = create_singlethread_workqueue("kvm-pit-wq");`
`698`	`698`	`if (!pit->wq) {`
`699`	`699`	`mutex_unlock(&pit->pit_state.lock);`
	`700`	`+ kvm_free_irq_source_id(kvm, pit->irq_source_id);`
`700`	`701`	`kfree(pit);`
`701`	`702`	`return NULL;`
`702`	`703`	`}`