[RR] Update Rolling Release for Rocky10 #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The regex was not prepared for Rocky10 Tags in the header. This likely needs reworked but this is the unblocking commit.
PlaidCat
requested review from
kerneltoast,
bmastbergen,
thefossguy-ciq,
shreeya-patel98 and
Copilot
There was a problem hiding this comment.
Pull Request Overview
This PR updates the regex in rolling-release-update.py to correctly match Rocky10 kernel tags in addition to existing EL8/EL9 tags.
- Expanded the regex to accept
el10(and other two-digit EL versions). - Adjusted the
kernel_vercapture group accordingly.
Comments suppressed due to low confidence (3)
rolling-release-update.py:165
- [nitpick] The variable
ris quite generic; consider renaming it tomatch_objormatchfor clearer intent.
r = re.match(b'.*(?P<vendor>.*)_kernel-(?P<kernel_ver>[0-9.-]*el[0-9]{1,2}_[0-9]*)', line)
rolling-release-update.py:165
- Add unit tests covering EL8, EL9, and EL10 tag formats to ensure the updated regex matches all expected cases and prevent regressions.
r = re.match(b'.*(?P<vendor>.*)_kernel-(?P<kernel_ver>[0-9.-]*el[0-9]{1,2}_[0-9]*)', line)
rolling-release-update.py:165
- [nitpick] Include a brief comment explaining this regex pattern and what the
vendorandkernel_vergroups capture to aid future maintainers.
r = re.match(b'.*(?P<vendor>.*)_kernel-(?P<kernel_ver>[0-9.-]*el[0-9]{1,2}_[0-9]*)', line)
Comment on lines
162
to
+165
| for line in results.stdout.split(b'\n'): | ||
| if b'tag: resf_kernel' in line: | ||
| print(line) | ||
| r = re.match(b'.*(?P<vendor>.*)_kernel-(?P<kernel_ver>[0-9.-]*el[89]_[0-9]*)', line) | ||
| r = re.match(b'.*(?P<vendor>.*)_kernel-(?P<kernel_ver>[0-9.-]*el[0-9]{1,2}_[0-9]*)', line) |
There was a problem hiding this comment.
[nitpick] Consider compiling this regex once (e.g. with re.compile(...)) outside the loop to avoid re-compiling on every iteration and improve performance.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex was not prepared for Rocky10 Tags in the header. This likely needs reworked but this is the unblocking commit.
Produced Desired Results
Designated by
>