59 git repository accessor failing to manage path structure #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ries and repositories. changed all corresponding tests.
…stly changes in the registries module. fix: from_git now correctly locates the repository content in the desired path set in model_config. incremented timeout for Zenodo requests. ft: get_source methods are now different for TimeDependent and TimeIndependent. Expanded git and zenodo accessors to handle end-cases, and to become adapted to the type of model structure (e.g., src or files). tests: updated corresponding unit tests, and expanded integration tests to catch more end-cases when querying a model from a repository.
…o raising Exception, so it can be catched by unit tests. Fix all type hintings not compatible with python 3.9. tests: local git repo now has author, so tests can be run in CI or closed envs. Fixed relative paths and dir testing, to make it compatible with MACOS. All Zenodo tests can be skipped if they doesnt work. Connection can be unstable, and not working every time.
…hey are compatible with MacOS CI
…tories in macos CI are handled differently
pabloitu
deleted the
59-git-repository-accessor-failing-to-manage-path-structure
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refac: changing os.path for pathlib across the application, having mostly changes in the registries module.
fix: from_git now correctly locates the repository content in the desired path set in model_config. incremented timeout for Zenodo requests.
ft: get_source methods are now different for TimeDependent and TimeIndependent. Expanded git and zenodo accessors to handle end-cases, and to become adapted to the type of model structure (e.g., src or files).
tests: updated corresponding unit tests, and expanded integration tests to catch more end-cases when querying a model from a repository.