CSense detects `Throws` annotation only if lambda provides `callsInPlace` contract

[and-marsh]

Hey, good job with the plugin!

I have noticed the following behavior, and I was wondering if it's intended or forced by some internal limitations. Here is the snippet where I call the function that throws inside of a lambda function. In such a scenario, CSense doesn't detect if the exception is handled or not.

And the warning disappears if the lambda function provides an "InPlace" contract:

This might not be related, but I suppose it's ok to file it here. Even with the "InPlace" contract, there is no suggestion to add an annotation to the function, only wrap it with try/catch:

Thanks in advance for looking into it!

[Tvede-dk]

Hi,
And thanks for reporting :)
The first thing is that the plugin does not do any kind of deep analysis, that would kill performance. Thus it needs to know from each method how to treat it.

There are 2 (3) ways the plugin knows that a given method rethrows the exception. contract with calls in place is one of those. Another is an entry in the ".callthough.throws" file. (unfortunatly that seems to be missing from the quickfix actions as well). 3 is a feature I'm working on, where you can apply an annotation (but this is quite complicated and takes some time)

The format of the ".callthough.throws" and ".ignore.throws" files are the same, so it should be pretty simple to at least manually fix it for now, until a fix is provided.

and finally, yes, that is a bug, it should suggest both to add the entry to ".callthough.throws" and to annotate the method.

[and-marsh]

Thanks for the response!

Great to have some options for workaround, but looking forward to the more refined solution as well!

[Tvede-dk]

It should be fixed in the comming 2.1.2 :)
(should be out in about 2 days)