Add ci job for simd models tests, with logging of rng seed. #5
+303
−74
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@W95Psp I am interested in your feedback on this, especially about my implementation using mutex and static for having the same rng everywhere (which is necessary to ensure reproducibility from the seed we log. |
W95Psp
reviewed
Aug 27, 2025
|
@karthikbhargavan This is ready and passes CI. Once it gets merged to the main branch of our fork, it will be in the upstream PR. |
karthikbhargavan
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses part of the feedback in the PR to the upstream repo:
I also added some logging of input value on assertion failures which might also be useful to debug test failures.