Skip to content

Conversation

thomas-nguy
Copy link

Closes: #587

Remove hard coded cap

Description

Remove hard coded cap, use flag instead


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@thomas-nguy thomas-nguy requested a review from a team as a code owner July 25, 2025 02:05
@thomas-nguy thomas-nguy requested review from calvinaco and songgaoye and removed request for a team July 25, 2025 02:05
@thomas-nguy thomas-nguy marked this pull request as draft July 25, 2025 02:05
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

❌ Patch coverage is 44.73684% with 21 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.82%. Comparing base (2b2eb9b) to head (b053551).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/keeper/grpc_query.go 34.37% 19 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #678      +/-   ##
===========================================
- Coverage    45.86%   45.82%   -0.04%     
===========================================
  Files          182      182              
  Lines        18194    18218      +24     
===========================================
+ Hits          8344     8348       +4     
- Misses        9134     9152      +18     
- Partials       716      718       +2     
Files with missing lines Coverage Δ
evmd/app.go 78.08% <100.00%> (+0.03%) ⬆️
x/evm/keeper/keeper.go 83.21% <100.00%> (+0.12%) ⬆️
x/evm/types/tx_args.go 100.00% <100.00%> (ø)
x/evm/keeper/grpc_query.go 74.05% <34.37%> (-2.52%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thomas-nguy thomas-nguy force-pushed the thomas/add-query-gas-limit branch from 226b1d1 to 2bff7ef Compare July 25, 2025 08:03
@thomas-nguy thomas-nguy marked this pull request as ready for review July 25, 2025 09:12
Copy link

@songgaoye songgaoye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomas-nguy thomas-nguy force-pushed the thomas/add-query-gas-limit branch from b79fa7d to fbd409c Compare July 28, 2025 06:35
@thomas-nguy thomas-nguy merged commit 83ae12e into crypto-org-chain:develop Jul 30, 2025
48 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove hardcoded MaxGasCap

2 participants