Skip to content

Conversation

yihuang
Copy link

@yihuang yihuang commented Apr 8, 2025

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe April 8, 2025 03:51
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.13%. Comparing base (03a1f12) to head (c4fdccd).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
x/evm/types/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #577   +/-   ##
========================================
  Coverage    46.13%   46.13%           
========================================
  Files          181      181           
  Lines        18186    18186           
========================================
  Hits          8390     8390           
  Misses        9076     9076           
  Partials       720      720           
Files with missing lines Coverage Δ
x/evm/types/utils.go 31.57% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yihuang yihuang merged commit f2ae8e8 into crypto-org-chain:develop Apr 8, 2025
37 of 39 checks passed
@yihuang yihuang deleted the develop branch April 8, 2025 06:27
yihuang pushed a commit that referenced this pull request Apr 8, 2025
* Problem: eth_getLogs miss logs with batch transactions. (#577)

* Problem: eth_getLogs miss logs with batch transactions.

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>

* fix ci

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants