Problem: params not cached in object store #454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
commented
Apr 5, 2024
yihuang
commented
Apr 5, 2024
mmsqe
reviewed
Apr 5, 2024
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| k.WithChainID(ctx) | ||
|
|
||
| // cache params object | ||
| _ = k.GetParams(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
| store := k.storeService.OpenKVStore(ctx) | ||
| bz, err := store.Get(types.KeyPrefixParams) | ||
| if err != nil { | ||
| panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods
mmsqe
approved these changes
Apr 5, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #454 +/- ##
===========================================
+ Coverage 62.79% 62.92% +0.13%
===========================================
Files 127 127
Lines 12038 12067 +29
===========================================
+ Hits 7559 7593 +34
+ Misses 3936 3933 -3
+ Partials 543 541 -2
|
Solution: - save the cost of repeated encoding/decoding during the block execution - also migrate existing transient stores to object stores Update CHANGELOG.md Signed-off-by: yihuang <[email protected]> Update x/feemarket/types/keys.go Signed-off-by: yihuang <[email protected]> renmae fix test
6 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)