Problem: parallel transaction execution is not supported #414

yihuang · 2024-03-08T08:22:28Z

Closes: #432

Description

Integrate go-block-stm to do parallel tx execution.

refactored the transient stores to be tx-index based, so the tx execution don't conflicts
add a patch call after all txs executed to decide the tx index/log size stuff.

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

testutil/network/network.go

rpc/stream/rpc.go

 	}

-	go s.start(&s.wg, chHeaders, chTx, chLogs)
+	go s.start(&s.wg, chBlocks, chTx, chLogs)


x/feemarket/keeper/params.go

x/evm/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/feemarket/module.go

-func (am AppModule) BeginBlock(ctx sdk.Context, req abci.RequestBeginBlock) {
-	am.keeper.BeginBlock(ctx, req)
+func (am AppModule) BeginBlock(ctx context.Context) error {
+	return am.keeper.BeginBlock(sdk.UnwrapSDKContext(ctx))


x/feemarket/module.go

app/app.go

+	for _, key := range app.keys {
+		keys = append(keys, key)
+	}


app/app.go

+	for _, key := range app.tkeys {
+		keys = append(keys, key)
+	}


app/app.go

x/evm/keeper/abci.go

x/evm/module.go

x/feemarket/keeper/abci.go

CHANGELOG.md

app/executor.go

codecov · 2024-03-20T13:41:23Z

Codecov Report

Attention: Patch coverage is 10.46512% with 77 lines in your changes are missing coverage. Please review.

Project coverage is 63.39%. Comparing base (4e8c133) to head (be0cadf).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #414      +/-   ##
===========================================
+ Coverage    62.94%   63.39%   +0.44%     
===========================================
  Files          127      127              
  Lines        12062     9599    -2463     
===========================================
- Hits          7593     6085    -1508     
+ Misses        3930     2977     -953     
+ Partials       539      537       -2

Files	Coverage Δ
x/evm/keeper/abci.go	`100.00% <100.00%> (ø)`
x/evm/keeper/gas.go	`88.88% <ø> (-0.86%)`	⬇️
x/evm/types/chain_config.go	`59.39% <100.00%> (+7.27%)`	⬆️
x/evm/types/logs.go	`100.00% <100.00%> (ø)`
x/evm/types/msg.go	`66.98% <0.00%> (+2.66%)`	⬆️
server/config/config.go	`35.44% <14.28%> (+4.98%)`	⬆️
app/app.go	`76.69% <18.18%> (-3.83%)`	⬇️
app/executor.go	`5.26% <0.00%> (-44.74%)`	⬇️

... and 112 files with indirect coverage changes

x/feemarket/keeper/abci.go

yihuang · 2024-03-22T01:44:35Z

put to draft for now until we get the sdk ready.

app/app.go

+	for _, key := range app.memKeys {
+		keys = append(keys, key)
+	}


app/app.go

+	for _, key := range app.okeys {
+		keys = append(keys, key)
+	}


app/executor.go

- integrate go-block-stm as tx executor - small optimiations fix

x/evm/types/utils.go

x/evm/types/interfaces.go

x/evm/keeper/abci.go

server/config/config.go

Signed-off-by: yihuang <[email protected]>

server/config/toml.go

Signed-off-by: yihuang <[email protected]>

fix config

yihuang marked this pull request as draft March 8, 2024 08:22

github-advanced-security bot found potential problems Mar 8, 2024

View reviewed changes

yihuang force-pushed the block-stm branch from 4513f12 to 7bf66d5 Compare March 17, 2024 06:54

github-advanced-security bot found potential problems Mar 17, 2024

View reviewed changes

yihuang force-pushed the block-stm branch 3 times, most recently from af6bc09 to c618235 Compare March 17, 2024 07:50

github-advanced-security bot found potential problems Mar 17, 2024

View reviewed changes

x/feemarket/keeper/abci.go Fixed Show fixed Hide fixed

yihuang force-pushed the block-stm branch 4 times, most recently from 9b11664 to 2e734ed Compare March 20, 2024 09:48

yihuang requested a review from mmsqe March 20, 2024 09:48

yihuang marked this pull request as ready for review March 20, 2024 09:49

yihuang commented Mar 20, 2024

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

yihuang commented Mar 20, 2024

View reviewed changes

app/executor.go Outdated Show resolved Hide resolved

github-advanced-security bot found potential problems Mar 21, 2024

View reviewed changes

x/feemarket/keeper/abci.go Fixed Show fixed Hide fixed

mmsqe approved these changes Mar 21, 2024

View reviewed changes

yihuang marked this pull request as draft March 22, 2024 01:44

yihuang mentioned this pull request Mar 25, 2024

[EPIC] block-stm integration #432

Closed

7 tasks

yihuang force-pushed the block-stm branch 2 times, most recently from 2850251 to 4ae414b Compare April 4, 2024 20:21

github-advanced-security bot found potential problems Apr 4, 2024

View reviewed changes

yihuang force-pushed the block-stm branch from 4ae414b to 4f7d6a0 Compare April 5, 2024 07:54

yihuang marked this pull request as ready for review April 5, 2024 07:54

yihuang requested a review from mmsqe April 5, 2024 07:54

mmsqe reviewed Apr 5, 2024

View reviewed changes

app/executor.go Outdated Show resolved Hide resolved

Problem: go-block-stm is not integrated for parallel tx execution

b2b9f03

- integrate go-block-stm as tx executor - small optimiations fix

package deps

b0802fb

yihuang force-pushed the block-stm branch from 3fb5bb6 to b0802fb Compare April 8, 2024 01:28

HuangYi added 3 commits April 8, 2024 09:30

cleanup

a5b1f1c

update sdk deps

3e1a59a

cleanup

82336f2

mmsqe reviewed Apr 8, 2024

View reviewed changes

x/evm/types/utils.go Outdated Show resolved Hide resolved

x/evm/types/interfaces.go Outdated Show resolved Hide resolved

x/evm/keeper/abci.go Show resolved Hide resolved

HuangYi added 2 commits April 8, 2024 09:44

cleanup

67d0384

cleanup

8671ed4

mmsqe approved these changes Apr 8, 2024

View reviewed changes

yihuang commented Apr 8, 2024

View reviewed changes

server/config/config.go Outdated Show resolved Hide resolved

Update server/config/config.go

09cfe39

Signed-off-by: yihuang <[email protected]>

yihuang commented Apr 8, 2024

View reviewed changes

server/config/toml.go Outdated Show resolved Hide resolved

yihuang added 2 commits April 8, 2024 09:54

Update server/config/toml.go

069eff5

Signed-off-by: yihuang <[email protected]>

cleanup

2f44dde

yihuang force-pushed the block-stm branch from 4b05c05 to 2f44dde Compare April 8, 2024 01:55

HuangYi added 2 commits April 8, 2024 09:56

cleanup

dac706a

cleanup

49a93b2

yihuang enabled auto-merge (squash) April 8, 2024 01:58

yihuang disabled auto-merge April 8, 2024 02:34

yihuang enabled auto-merge (squash) April 8, 2024 02:36

yihuang force-pushed the block-stm branch from 1fa0d73 to 423db7f Compare April 8, 2024 03:50

HuangYi and others added 3 commits April 8, 2024 13:37

fix default executor

60dde5e

Problem: codecov action v3 is pinging v4 (#458)

12caed9

fix test

b641c58

fix config

yihuang force-pushed the block-stm branch from 423db7f to b641c58 Compare April 8, 2024 05:38

Merge branch 'develop' into block-stm

be0cadf

yihuang merged commit e5c3a1c into crypto-org-chain:develop Apr 8, 2024

yihuang deleted the block-stm branch April 8, 2024 06:18

Uh oh!

Problem: parallel transaction execution is not supported #414

Problem: parallel transaction execution is not supported #414

Uh oh!

Conversation

yihuang commented Mar 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check notice

Uh oh!

Check warning

Check warning

Uh oh!

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Mar 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

yihuang commented Mar 22, 2024

Uh oh!

Check warning

Check warning

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

yihuang commented Mar 8, 2024 •

edited

Loading

codecov bot commented Mar 20, 2024 •

edited

Loading