Skip to content

perf: optimise staking endblocker #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 121 commits into from
Oct 15, 2025
Merged

perf: optimise staking endblocker #1850

merged 121 commits into from
Oct 15, 2025

Conversation

thomas-nguy
Copy link
Collaborator

@thomas-nguy thomas-nguy commented Aug 20, 2025 •
edited by randy-cro
Loading

Description

Optimise staking endblocker

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

mmsqe and others added 26 commits December 9, 2024 12:06
@mmsqe
Problem: recent bug fixes are not included (crypto-org-chain#1715)
892db65 
* Problem: rocksdb 9.8.4 is not used (crypto-org-chain#1712)

for more info, facebook/rocksdb@v9.7.4...v9.8.4

* Problem: query blocks before enable feemarket module get nil pointer error (crypto-org-chain#1714)

* Problem: unable to query historical txs whose module is removed (crypto-org-chain#1713)

* Problem: unable to query historical txs from deleted icaauth module

* test

* poetry

* deps

* add unit tets

* cleanup

* rename

* revert integration test

* revert

* add authz

* changelog

* test authz

* cleanup

* register in query

* only patch encoding for tx service

* Revert "only patch encoding for tx service"

This reverts commit 4b1c141.

---------

Co-authored-by: HuangYi <[email protected]>

---------

Co-authored-by: HuangYi <[email protected]>
Problem: v1.4.1 is not released (crypto-org-chain#1716)
3c6ce90 
* Problem: v1.4.1 is not released

`v1.4.1` fixes 2 RPC issues, it's highly recommended for node
operators to use this version to the v1.4 mainnet upgrade.

* bump
@mmsqe
Problem: fix of performance regression after upgrade in iavl is not i…
447007d 
…ncluded (crypto-org-chain#1720) (crypto-org-chain#1721)

* Problem: query with iavl legacy iterator is not tested

call_trace

cleanup

* test fix

* add assert

* add go

* update deps

* revert test
@mmsqe
Problem: restriction of same sender tx appear in the same tx after co…
649fd58 
…ntract creation is not included (crypto-org-chain#1723)

* Problem: restriction of same sender tx appear in the same tx after contract creation is not included

* integration test

* cleanup

* cleanup

---------

Co-authored-by: HuangYi <[email protected]>
@mmsqe
Problem: fix of deadlock when close tree is not included (crypto-org-…
12c286f 
…chain#1726)
@mmsqe
Problem: v0.50.x is outdated (crypto-org-chain#1727)
664a240
@mmsqe
Problem: v1.4.2 is not released (crypto-org-chain#1728)
65f7de9 
Co-authored-by: mmsqe <[email protected]>
Problem: cometbft not up to date (crypto-org-chain#1736)
24a0fcf 
* Problem: cometbft not up to date

* changelog

* bump version
@mmsqe
Problem: recent fixdata fixes are not included (crypto-org-chain#1749)
873900d 
* Problem: miss diff info when assert from test utils (crypto-org-chain#1745)

* Problem: miss diff info when assert from test utils

* align rootdir

* fix upload

* Problem: batch initialization when fixdata with dry-run is unnecessary (crypto-org-chain#1747)

* Problem: need batch initialization run fixdata with dry-run

* mod tidy

* skip flush

* Problem: need run fixdata multiple times when no timestamp checking

query with GetCFWithTS to compare both timestamp and key
@mmsqe
Problem: recent bug fixes are not included (crypto-org-chain#1754)
d832bc1 
* Problem: unable to resolve octokit action v2.0.0 (crypto-org-chain#1750)

for more info, https://github.com/crypto-org-chain/cronos/actions/runs/13386690642

* Problem: conflict of index uniqueness constrain violation on trace api (crypto-org-chain#1753)

* Problem: conflict of index uniqueness constrain violation on trace api

* test

* update deps

* bump go

* Problem: slices in ReadOptions is freed by gc while referenced in rocksdb (crypto-org-chain#1751)

* Problem: no deallocate read options

* doc

* sync deps

* add doc

* Problem: ReadOptions mutated by reference release in iterator fix is not included

* deps
@mmsqe
Problem: ibc-go is not up to date (crypto-org-chain#1761)
46c94b7 
* Problem: ibc-go is not up to date

* bump version

---------

Co-authored-by: HuangYi <[email protected]>
Problem: version mismatch happen occasionally (backport crypto-org-ch…
d0078eb 
…ain#1759) (crypto-org-chain#1765)

* Problem: version mismatch happen occationally

Solution:
- make sure don't load iavl version ahead of versiondb

* changelog

* Update app/app.go



* memiavl support write old version idopodently

* add unit test

* fix upgrade store loader

* reproduce in integration test

* fix memiavl

* better test

* fix lint

---------

Signed-off-by: yihuang <[email protected]>
Problem: security patch from ibc-go is not included (backport: crypto…
6aa7e3f 
…-org-chain#1766) (crypto-org-chain#1767)

* Problem: security patch from ibc-go is not included (backport: crypto-org-chain#1766)

* bump version
@mmsqe
Problem: memiavl too strict on target version (backport crypto-org-ch…
7a5fc5f 
…ain#1780) (crypto-org-chain#1781)

* Problem: memiavl too strict on target version (backport crypto-org-chain#1780)

When consolidate minimal version between memiavl and versiondb, we
expect memiavl to load up to the target version, rather than exact
target version.

Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* Update CHANGELOG.md

Co-authored-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Signed-off-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>
@mmsqe
Problem: eth_getLogs miss logs with batch transactions (crypto-org-ch…
f3691c6 
…ain#1783)

* Problem: eth_getLogs miss logs with batch transactions

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

* deps

* cleanup

---------

Signed-off-by: yihuang <[email protected]>
Co-authored-by: mmsqe <[email protected]>
Problem: eth_getLogs bug not reproduced in integration test (crypto-o…
b4dcb4a 
…rg-chain#1784)

* Problem: eth_getLogs bug not reproduced in integration test

* fix py lint
Problem: ethermint bug fixes not included (crypto-org-chain#1785)
d154170 
* Problem: ethermint bug fixes not included

* Update CHANGELOG.md

Signed-off-by: yihuang <[email protected]>

---------

Signed-off-by: yihuang <[email protected]>
Problem: testground image build fail (crypto-org-chain#1786)
f6d0fed
@thomas-nguy
[Problem] cosmos sdk does not include latest bugfixes (crypto-org-cha…
2e2f2cd 
…in#1796)
@mmsqe @bobby-lin-cdc
Problem: changelog is outdated (crypto-org-chain#1788)
49758a0 
* Problem: changelog is outdated

* bump changed-files

* pin gha hash (crypto-org-chain#1792)

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: mmsqe <[email protected]>

* fix resolve

---------

Signed-off-by: mmsqe <[email protected]>
Co-authored-by: bobby-lin-cdc <[email protected]>
@thomas-nguy
feat: add support for eth_getBlockReceipts (crypto-org-chain#1817)
3474cc4 
* add support eth_getBlockReceipts

* update go mod

* update gomod2nix.toml

* add test for blockReceipts

* python lint
@thomas-nguy
release: v1.4.8 (crypto-org-chain#1820)
513fda7
@thomas-nguy
fix(rpc): add sanity check to trace_tx and trace_call (crypto-org-cha…
9e48eca 
…in#1830)
@thomas-nguy
fix(grpc): add sanity check to trace_tx follow up (crypto-org-chain#1832
02378a3 
)
@thomas-nguy
release v1.4.9 (crypto-org-chain#1833)
186ea49
@thomas-nguy
optimize end blocker
aa3fb23
@thomas-nguy thomas-nguy requested a review from a team as a code owner August 20, 2025 08:38
@thomas-nguy thomas-nguy requested review from XinyuCRO and songgaoye and removed request for a team August 20, 2025 08:38
@randy-cro randy-cro changed the base branch from release/v1.4.x to release/v1.5.x September 30, 2025 04:49
@randy-cro randy-cro force-pushed the thomas/optimize-end-blocker branch from 5a91fb2 to 19317d6 Compare October 1, 2025 04:55
@github-actions github-actions bot added the nix label Oct 2, 2025
@socket-security Socket Security
Copy link

socket-security bot commented Oct 6, 2025 •
edited
Loading

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatedgolang/​github.com/​crypto-org-chain/​ethermint@​v0.22.1-0.20250917021453-86f043d7a76a ⏵ v0.22.1-0.20251015052624-86bca6e73a8875 +110010010070
Updatedgolang/​github.com/​crypto-org-chain/​cosmos-sdk@​v0.50.6-0.20250424063720-28ea58ae20d8 ⏵ v0.50.6-0.20251015030247-d8ed3ff5806b76 +1100100100100
Updatedgolang/​github.com/​linxGnu/​grocksdb@​v1.9.10-0.20250331012329-9d5f074653d1 ⏵ v1.10.2100 +1100100100100

View full report

@randy-cro randy-cro enabled auto-merge (squash) October 15, 2025 04:10
@randy-cro randy-cro disabled auto-merge October 15, 2025 04:40
@randy-cro randy-cro enabled auto-merge (squash) October 15, 2025 05:37
@randy-cro randy-cro merged commit 8962f13 into crypto-org-chain:release/v1.5.x Oct 15, 2025
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JayT106 JayT106 JayT106 left review comments

@randy-cro randy-cro randy-cro approved these changes

@XinyuCRO XinyuCRO Awaiting requested review from XinyuCRO XinyuCRO is a code owner automatically assigned from crypto-org-chain/cronos-dev

@songgaoye songgaoye Awaiting requested review from songgaoye songgaoye is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees

No one assigned

Labels

nix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomas-nguy @JayT106 @randy-cro @mmsqe