Problem: v1.4.6 is not backported #1787
Conversation
mmsqe
requested review from
thomas-nguy and
yihuang
and removed request for
a team
WalkthroughThis pull request updates the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
CHANGELOG.md (5)
5-10: Clarify the Unreleased Section and Planned DateThe "UNRELEASED" section now starts with an "### Improvements" header and includes the entry for upgrading rocksdb (line 7) with the date "Apr 9, 2025". Please verify that the planned release date is intentional and clearly differentiated from later released sections. It might help to add context (or a note) indicating that these changes are still upcoming.
11-17: Review v1.4.6 Bug FixesIn the v1.4.6 section, the bug fixes for eth_getLogs edge case (line 15) and ethermint bug fixes (line 16) are clearly listed. It would be good to double-check that the descriptions precisely reflect the nature of the fixes. Also, consider a minor rephrasing for clarity (e.g. “Fix eth_getLogs edge case in batch transactions”).
24-32: Examine v1.4.5 Bug Fixes and Security PatchIn the v1.4.5 section (lines 26–30), two bug fix entries are added. Consider revising “Fix version mismatch happen occasionally” to a clearer phrasing such as “Fix occasional version mismatches.” Also, note that the security patch entry (line 29) specifies from ibc-go as
v8.7.0; please verify that the versioning and punctuation in this entry are consistent with similar entries in other sections.
37-42: Assess v1.4.4 Updates for ConsistencyWithin the v1.4.4 section, two new entries are marked as changes (lines 39 and 41). One adds support for legacy global AccountNumber and the other includes a security patch from ibc-go. Please ensure that the level of detail and formatting for these entries matches the standards used in other version sections—for example, whether to include patch version details consistently.
47-56: Review v1.4.3 Section AdditionsThe newly added v1.4.3 section (lines 47–56) includes a bug fix updating cometbft (line 53) with the release date "Dec 19, 2024". Confirm that the introduction of this section fits the project’s changelog structure and that the release dates are accurately aligned with your release schedule.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
CHANGELOG.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: semgrep-cloud-platform/scan
🔇 Additional comments (1)
CHANGELOG.md (1)
18-23: Validate v1.4.6 Improvements DetailThe improvements subsection in v1.4.6 (lines 18–20) introduces the change to memiavl’s LoadVersion behavior. The description is concise and clear. Please confirm that the phrase “loads up to the target version instead of exact version” accurately conveys the technical change. The release date "Mar 13, 2025" (line 22) fits here, but ensure that its chronological relation with the UNRELEASED section is as intended.
mmsqe
changed the title
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1787 +/- ##
===========================================
+ Coverage 16.87% 35.55% +18.67%
===========================================
Files 72 127 +55
Lines 6163 11963 +5800
===========================================
+ Hits 1040 4253 +3213
- Misses 5000 7282 +2282
- Partials 123 428 +305 🚀 New features to boost your workflow:
|
thomas-nguy
changed the title
thomas-nguy
changed the title
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
CHANGELOG.md (4)
5-10: New UNRELEASED Improvements Section AddedThe new improvements entry for upgrading rocksdb to
v9.11.2is clear and concise. Please verify that the date formatting (e.g. "Apr 9, 2025") and heading style align with the project’s changelog conventions.🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
9-9: Emphasis used instead of a heading
null(MD036, no-emphasis-as-heading)
15-16: v1.4.6 Bug Fixes – Edge Case and Ethermint UpdatesThe bug fixes for eth_getLogs (line 15) and the inclusion of ethermint bug fixes (line 16) are well-documented with proper PR references. However, the URL in the parentheses for [#1785] is a bare URL. To improve consistency and adhere to markdown best practices, consider formatting it as a proper markdown link.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
16-16: Bare URL used
null(MD034, no-bare-urls)
28-29: v1.4.5 Bug Fixes – Version Mismatch and Security PatchThe fixes addressing the version mismatch and the inclusion of the ibc-go security patch are explained well. Consider rephrasing “Fix version mismatch happen occasionally” to “Fix occasional version mismatch” for better grammatical clarity.
46-47: v1.4.4 Improvements – Batch Initialization and Flush BehaviorThe improvement entry for skipping batch initialization and flush when using a dry-run (line 46) is clear. For clarity, consider rephrasing “avoid run fixdata multiple times” (as mentioned in the related bug fix entry) to “avoid multiple executions of fixdata.”
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
47-47: Emphasis used instead of a heading
null(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)go.mod(1 hunks)gomod2nix.toml(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- go.mod
- gomod2nix.toml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
CHANGELOG.md
9-9: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
16-16: Bare URL used
null
(MD034, no-bare-urls)
22-22: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
31-31: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
47-47: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
55-55: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
⏰ Context from checks skipped due to timeout of 90000ms (16)
- GitHub Check: integration_tests (gas)
- GitHub Check: integration_tests (slow)
- GitHub Check: integration_tests (upgrade)
- GitHub Check: integration_tests (gov)
- GitHub Check: integration_tests (ica)
- GitHub Check: integration_tests (ibc_update_client)
- GitHub Check: integration_tests (ibc_timeout)
- GitHub Check: integration_tests (ibc_rly_gas)
- GitHub Check: build (macos-14)
- GitHub Check: integration_tests (ibc_rly_evm)
- GitHub Check: unittest
- GitHub Check: integration_tests (ibc)
- GitHub Check: build (macos-latest)
- GitHub Check: integration_tests (unmarked)
- GitHub Check: build (ubuntu-latest)
- GitHub Check: Run golangci-lint
🔇 Additional comments (2)
CHANGELOG.md (2)
20-22: v1.4.6 Improvements – memiavl LoadVersion BehaviorThe entry stating that "memiavl LoadVersion loads up to the target version instead of exact version" is succinct and clear. Ensure that any related documentation or upstream references reflect this change accurately.
🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
22-22: Emphasis used instead of a heading
null(MD036, no-emphasis-as-heading)
40-42: v1.4.4 Bug Fixes – Legacy AccountNumber Support and Security PatchIn the v1.4.4 section, the bug fixes include:
- Support for legacy global AccountNumber (line 40)
- A security patch from ibc-go (line 42)
Please verify that the ordering and grouping of these entries are intentional and that any duplicate mentions (if similar fixes appear in other versions) are deliberate. Consistency in the description across versions is important.
3 participants
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
for more info:
crypto-org-chain/ethermint@62042e2...434f46d
crypto-org-chain/cometbft@ce418f8...1964da4
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
Summary by CodeRabbit
Documentation
Bug Fixes
Chores