Allow functions to take arguments #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small generalization of your code to allow the functions to which constraints are applied to be able to take arguments. This allows for using multiple loss functions, constraining a model's output to be within a certain range, etc, etc.
As a proof of concept, you can append the following to the constraints in the MNIST example to constrain the output to sum to 50:
constraints.append(EqConstraint(torch.sum, 50, scale=scale, damping=damping))and then change the mdmm_module call to:
mdmm_return = mdmm_module(loss, [None, None, None, outputs])The first 3 Nones are for the three constraints that take no argument, while the last constraint we added will take
outputs. That's all that's needed to make it work.The change is backward compatible and no list is required if no constraint functions need arguments. Also functions that require multiple arguments, like a secondary loss, can have their arguments provided as a tuple or list within the argument list.