Skip to content

Conversation

neuschaefer
Copy link
Contributor

@neuschaefer neuschaefer commented Sep 25, 2025

This PR adds support for the aarch64_be-unknown-linux-gnu target. It uses crosstool-ng because Debian/Ubuntu does not provide cross-compilers for aarch64_be.

@Emilgardis
Copy link
Member

/ci try -t aarch64_be-unknown-linux-gnu

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member

Did you forget to add the dockerfile? :D

@neuschaefer
Copy link
Contributor Author

Did you forget to add the dockerfile? :D

I forgot to write it, because I didn't know how this part of cross works :)

@Emilgardis
Copy link
Member

Emilgardis commented Sep 26, 2025

the dockerfile is essential for providing the cross-compilation tools needed for C (and other) deps. Just pure rust will work fine withut cross

@neuschaefer neuschaefer force-pushed the a64be-gnu branch 2 times, most recently from 1c856cd to 955b2bf Compare September 26, 2025 14:50
@neuschaefer neuschaefer marked this pull request as ready for review September 26, 2025 15:14
@neuschaefer neuschaefer requested a review from a team as a code owner September 26, 2025 15:14
@Emilgardis
Copy link
Member

/ci try -t aarch64_be-unknown-linux-gnu

This comment has been minimized.

This comment has been minimized.

@Emilgardis
Copy link
Member

/ci try -t aarch64_be-unknown-linux-gnu

This comment has been minimized.

Copy link

Try run for comment

Successful Jobs

@Emilgardis Emilgardis added the CI-aarch64_be-unknown-linux-gnu Run CI for aarch64_be-unknown-linux-gnu target label Sep 27, 2025
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, one question :)

docker/common.sh Outdated
Comment on lines 28 to 46
bzip2 \
ca-certificates \
curl \
file \
gcc \
git \
libtool \
m4 \
make

if_centos install_packages \
clang-devel \
gcc-c++ \
gcc-gfortran \
glibc-devel \
pkgconfig

if_ubuntu install_packages \
adduser \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both bzip2 and adduser were necessary during the build. I'm rerunning it now to give a more detailed answer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both of them are due to crosstool-ng.sh, so I'm moving the installations there, and documenting the reasons in the commit message

Two new packages are installed in crosstool-ng.sh because they aren't
preinstalled in the Ubuntu 24.04 base image:

- adduser is directly invoked in the script
- bzip2 is needed while building crosstool-ng
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-aarch64_be-unknown-linux-gnu Run CI for aarch64_be-unknown-linux-gnu target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants