-
Notifications
You must be signed in to change notification settings - Fork 425
Add aarch64_be-unknown-linux-gnu target #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
6609256
to
743fdd4
Compare
/ci try -t aarch64_be-unknown-linux-gnu |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Did you forget to add the dockerfile? :D |
I forgot to write it, because I didn't know how this part of cross works :) |
the dockerfile is essential for providing the cross-compilation tools needed for C (and other) deps. Just pure rust will work fine withut cross |
1c856cd
to
955b2bf
Compare
/ci try -t aarch64_be-unknown-linux-gnu |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
955b2bf
to
3d5ab8c
Compare
/ci try -t aarch64_be-unknown-linux-gnu |
This comment has been minimized.
This comment has been minimized.
Try run for comment
Successful Jobs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, one question :)
docker/common.sh
Outdated
bzip2 \ | ||
ca-certificates \ | ||
curl \ | ||
file \ | ||
gcc \ | ||
git \ | ||
libtool \ | ||
m4 \ | ||
make | ||
|
||
if_centos install_packages \ | ||
clang-devel \ | ||
gcc-c++ \ | ||
gcc-gfortran \ | ||
glibc-devel \ | ||
pkgconfig | ||
|
||
if_ubuntu install_packages \ | ||
adduser \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both bzip2 and adduser were necessary during the build. I'm rerunning it now to give a more detailed answer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both of them are due to crosstool-ng.sh, so I'm moving the installations there, and documenting the reasons in the commit message
Two new packages are installed in crosstool-ng.sh because they aren't preinstalled in the Ubuntu 24.04 base image: - adduser is directly invoked in the script - bzip2 is needed while building crosstool-ng
3d5ab8c
to
a5c1c64
Compare
This PR adds support for the aarch64_be-unknown-linux-gnu target. It uses crosstool-ng because Debian/Ubuntu does not provide cross-compilers for aarch64_be.