Skip to content

Conversation

renan628
Copy link
Member

@renan628 renan628 commented Jan 3, 2023

Summary

This PR refactors the unit tests to check the type and the message of the expected error making use of toThrowWithMessage assertion from jest-extended lib.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@github-actions
Copy link

github-actions bot commented Jan 3, 2023

👋 @renan628

Thanks for your contribution!

The approval and merge process is almost fully automated 🧙

Here's how it works:

  1. You open a new pull request
  2. Automated tests check the code
  3. Maintainers review the code
  4. Once approved, the PR is ready to merge.

👉 Omit the extended description
Please remove the commit body before merging the pull request.
Instead, include the pull request number in the title to provide the full context
about the change.

☝️ Lastly, the title for the commit will come from the pull request title. So please provide a descriptive title that summarizes the changes in 50 characters or less using the imperative mood.

Happy coding! 🎉

@renan628 renan628 self-assigned this Jan 3, 2023
@renan628 renan628 added the maintenance Housekeeping label Jan 3, 2023
@renan628 renan628 changed the title Unit tests refactor to use to throw with message Refactor unit tests to use to throw with message Jan 3, 2023
@renan628 renan628 requested a review from guipfernandes January 3, 2023 21:37
@renan628 renan628 marked this pull request as ready for review January 3, 2023 21:37
@renan628 renan628 requested a review from guipfernandes January 4, 2023 20:40
@renan628 renan628 requested a review from Fryuni January 4, 2023 22:37
@Fryuni Fryuni requested a review from a team as a code owner January 12, 2023 20:48
@Fryuni Fryuni enabled auto-merge (squash) January 12, 2023 20:49
@Fryuni Fryuni merged commit 0702436 into master Jan 12, 2023
@Fryuni Fryuni deleted the refactor-throw-with-message branch January 12, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Housekeeping

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants