Skip to content

Conversation

@tpaulshippy
Copy link
Contributor

Purpose

In the process of building #50 I made a couple of mistakes.

  1. I ran the model refresh tests while credentials were not set to mask, bleeding them into the cassettes.
  2. I modified the signing code in such a way to break the model refresh.

Approach

Fix the second issue and then rerun the model refresh tests to fix the first.

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.11%. Comparing base (3fe4b12) to head (87953ff).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          71       71           
  Lines        2586     2588    +2     
  Branches      377      378    +1     
=======================================
+ Hits         2382     2384    +2     
  Misses        204      204           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@crmne crmne merged commit 81e8d55 into crmne:main Apr 2, 2025
7 checks passed
@tpaulshippy tpaulshippy deleted the bedrock-models branch April 16, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants