Skip to content

Conversation

@pekopekopekopayo
Copy link

@pekopekopekopayo pekopekopekopayo commented Nov 3, 2025

What this does

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation
  • Performance improvement

Scope check

  • I read the Contributing Guide
  • This aligns with RubyLLM's focus on LLM communication
  • This isn't application-specific logic that belongs in user code
  • This benefits most users, not just my specific use case

Quality check

  • I ran overcommit --install and all hooks pass
  • I tested my changes thoroughly
    • For provider changes: Re-recorded VCR cassettes with bundle exec rake vcr:record[provider_name]
    • All tests pass: bundle exec rspec
  • I updated documentation if needed
  • I didn't modify auto-generated files manually (models.json, aliases.json)

API changes

  • Breaking change
  • New public methods/classes
  • Changed method signatures
  • No API changes

Related issues

[FEATURE] Support for handling ActionDispatch::Http::UploadedFile in RubyLLM (filename is always nil) #468

@pekopekopekopayo pekopekopekopayo marked this pull request as draft November 3, 2025 09:47
@pekopekopekopayo pekopekopekopayo force-pushed the refactor/attachment-initialize branch from cc10195 to 6f76aec Compare November 3, 2025 10:07
@pekopekopekopayo pekopekopekopayo marked this pull request as ready for review November 3, 2025 10:07
@pekopekopekopayo
Copy link
Author

[FEATURE] Support for handling ActionDispatch::Http::UploadedFile in RubyLLM (filename is always nil) #468

@pekopekopekopayo pekopekopekopayo marked this pull request as draft November 3, 2025 10:11
@pekopekopekopayo pekopekopekopayo marked this pull request as draft November 3, 2025 10:11
@pekopekopekopayo pekopekopekopayo marked this pull request as ready for review November 3, 2025 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant