Skip to content

[FIX] return all labels for HCPex atlas #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 15, 2024
Merged

[FIX] return all labels for HCPex atlas #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71df91a
fix 117
Remi-Gau Mar 15, 2024
4ceb2c8
update action
Remi-Gau Mar 15, 2024
695166b
Merge remote-tracking branch 'origin/main' into fix/117
Remi-Gau Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/run_tests_matlab.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,14 @@ jobs:
strategy:
fail-fast: false
matrix:
version: [R2021a, R2021b, R2022a, R2022b]
version: [R2023b]
os: [ubuntu-latest, macos-latest, windows-latest]

runs-on: ${{matrix.os}}

steps:
- name: Install MATLAB
uses: matlab-actions/setup-matlab@v2.0.0
uses: matlab-actions/setup-matlab@v2.1.0
with:
release: ${{matrix.version}}

Expand All @@ -54,7 +54,7 @@ jobs:
run: make install_dev

- name: Run tests
uses: matlab-actions/run-command@v2.0.0
uses: matlab-actions/run-command@v2.1.0
with:
command: cd(fullfile(getenv('GITHUB_WORKSPACE'), '.github', 'workflows')); run tests_matlab;

Expand Down
2 changes: 1 addition & 1 deletion src/atlas/getLookUpTable.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@

fid = fopen(roiLabelLUT);
pattern = '%f%s%s%f';
C = textscan(fid, pattern, 'Headerlines', 1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question (bug_risk): Changing the 'Headerlines' parameter from 1 to 0 in the textscan function call will result in the first line of the file being read as data rather than being skipped as a header. Ensure that this change is intentional and that the first line of the file does not contain column headers or other metadata that should not be treated as data.

C = textscan(fid, pattern, 'Headerlines', 0);
fclose(fid);

for i = 1:numel(C{2})
Expand Down
4 changes: 2 additions & 2 deletions tests/test_getLookUpTable.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,8 @@ function test_lut_hcpex()

lut = getLookUpTable('hcpex');

assertEqual(lut.label, [2:426]');
assertEqual(lut.ROI{417}, 'R_Gpe');
assertEqual(lut.label, [1:426]');
assertEqual(lut.ROI{417}, 'R_NAc');

end

Expand Down