Fix force overwriting symlink issue (#20) #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 93.68% 93.39% -0.29%
==========================================
Files 4 4
Lines 95 106 +11
==========================================
+ Hits 89 99 +10
- Misses 6 7 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
shenxianpeng
changed the title
shenxianpeng
commented
Aug 12, 2022
Collaborator
Author
shenxianpeng
left a comment
shenxianpeng
left a comment
There was a problem hiding this comment.
Ready to review @2bndy5
2bndy5
reviewed
Aug 12, 2022
also make an assertion that the symlinked target exists before creating one
shenxianpeng
commented
Aug 13, 2022
This was
linked to
issues
Aug 13, 2022
Contributor
2bndy5
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.