Skip to content

[range.adaptor.object][range.adaptor.object] Index special kinds of function objects and their related operator| #8089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jul 18, 2025

As drive-by, also change \term to \defn in [customization.point.object] to index "customization point object".

Fixes #8052. Fixes #6967.

@@ -860,7 +860,7 @@
\rSec4[customization.point.object]{Customization Point Object types}

\pnum
A \term{customization point object} is a function object\iref{function.objects}
A \defn{customization point object} is a function object\iref{function.objects}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want \defn here and not, say, \defnadj?

Copy link
Contributor Author

@frederick-vs-ja frederick-vs-ja Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's better to say \defnadj{customization point}{object}, \defnadj{range adaptor closure}{object}, and \defnadj{range adaptor}{object}.
But for pipeable objects we're saying \defnadj{pipeable}{sender adaptor closure object} and \defnadj{pipeable}{sender adaptor object}, and there're no corresponding non-pipeable ones, which looks weird to me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I haven't looked in detail of how we're indexing all those things. It looks like you've spent some time on this; what would you recommend?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to say \defnadj{pipeable sender adaptor closure}{object}. It seems that the current indexing style of these things was decided by @jensmaurer during working on #7114. I'm not sure whether this was intended.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also paging @AlisdairM and @Eelis as indexing experts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

operator| for range adaptor closure objects is not in the index No index entry for customization point object
2 participants