Skip to content

P2875R4 Undeprecate polymorphic_allocator::destroy #6900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

AlisdairM
Copy link
Contributor

@AlisdairM AlisdairM commented Mar 24, 2024

@AlisdairM AlisdairM changed the title [P2875] Undeprecate polymorphic_allocator::destroy P2875R4 Undeprecate polymorphic_allocator::destroy Mar 24, 2024
\begin{itemdescr}
\pnum
\effects
Equivalent to \tcode{p->\~T()}.
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja Mar 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended to introduce SFINAE constraints implied by "Equivalent to" here ([structure.specifications]/4)? This seemingly makes the changes more than pure undeprecation.
I've attempted to file an LWG issue for this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not imply SFINAE. The use of "Effects: Equivalent to" means that other [structure.specifications] elements such as Constraints and Throws are inherited, but the delete-expression is not a standard library component and is not described by any specification using Constraints, Throws etc.

If it said "expression-equivalent to" that would imply SFINAE (and conditional noexcept etc).

@tkoeppe tkoeppe merged commit 5a38fd9 into cplusplus:main Apr 16, 2024
@AlisdairM AlisdairM deleted the P2875 branch July 28, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2024-03 LWG Motion 2] Undeprecate polymorphic_allocator::destroy for C++26 P2875 R4 Undeprecate polymorphic_allocator::destroy For C++26
5 participants