P2875R4 Undeprecate polymorphic_allocator::destroy #6900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisdairM
changed the title
| \begin{itemdescr} | ||
| \pnum | ||
| \effects | ||
| Equivalent to \tcode{p->\~T()}. |
There was a problem hiding this comment.
Is it intended to introduce SFINAE constraints implied by "Equivalent to" here ([structure.specifications]/4)? This seemingly makes the changes more than pure undeprecation.
I've attempted to file an LWG issue for this.
There was a problem hiding this comment.
This does not imply SFINAE. The use of "Effects: Equivalent to" means that other [structure.specifications] elements such as Constraints and Throws are inherited, but the delete-expression is not a standard library component and is not described by any specification using Constraints, Throws etc.
If it said "expression-equivalent to" that would imply SFINAE (and conditional noexcept etc).
jensmaurer
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6873
Fixes cplusplus/papers#1530