P2338R4 Freestanding Library: Character primitives and the C library #6356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Jun 27, 2023
There was a problem hiding this comment.
The application of the following instruction is missing:
Please add the following feature test macros to [version.syn]:
Note that such application introduces merge conflicts with #6355, as pointed out:
This paper also assumes that LWG3753 and P2198 have been accepted and applied.
jensmaurer
force-pushed
the
motions-2023-06-lwg-12
branch
from
bd3e4d1 to
e19ea42
Compare
JohelEGP
approved these changes
Jun 27, 2023
| size_t strspn(const char* s1, const char* s2); // freestanding | ||
| const char* strstr(const char* s1, const char* s2); // freestanding; see \ref{library.c} | ||
| char* strstr(char* s1, const char* s2); // freestanding; see \ref{library.c} | ||
| char* strtok(char* s1, const char* s2); // freestanding |
There was a problem hiding this comment.
strtok is now removed from freestanding library contents of C23 (see this documentation). Perhaps we need an LWG issue to strike strtok and wcstok.
There was a problem hiding this comment.
This is being handled by a future paper.
Editorial notes: - sort table [tab:headers.cpp.fs] by section number
tkoeppe
force-pushed
the
motions-2023-06-lwg-12
branch
from
e19ea42 to
9eaf064
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6298
Fixes cplusplus/papers#1017