Skip to content

P2340R1 Clarifying the status of the "C headers" #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2021
Merged

P2340R1 Clarifying the status of the "C headers" #5025

merged 2 commits into from
Oct 20, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 13, 2021
burblebee
burblebee requested changes Oct 15, 2021
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor request, see inline comment

@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed changes requested Changes to the wording or approach have been requested and not yet applied. labels Oct 15, 2021
@tkoeppe tkoeppe force-pushed the motions-2021-10-lwg-17 branch from bd8fe51 to 8c319b2 Compare October 20, 2021 11:33
Mick235711
Mick235711 reviewed Oct 20, 2021
View reviewed changes
jensmaurer
jensmaurer commented Oct 20, 2021
View reviewed changes
Copy link
Member Author

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit title
" [diff.mods.to.headers] Delete statement at C headers are deprecated."

at -> that

@tkoeppe tkoeppe force-pushed the motions-2021-10-lwg-17 branch from e744e96 to f8b37c4 Compare October 20, 2021 14:24
@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 20, 2021

@jensmaurer: Done, thanks!

@tkoeppe tkoeppe force-pushed the motions-2021-10-lwg-17 branch from f8b37c4 to 347ea54 Compare October 20, 2021 20:49
@tkoeppe tkoeppe merged commit 682525f into main Oct 20, 2021
@jensmaurer jensmaurer deleted the motions-2021-10-lwg-17 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe approved these changes

@JohelEGP JohelEGP JohelEGP left review comments

@Mick235711 Mick235711 Mick235711 left review comments

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
Development

Successfully merging this pull request may close these issues.

[2021-10 LWG Motion 17] P2340R1 Clarifying the status of the "C headers" P2340 Clarifying the status of the "C headers"
5 participants
@jensmaurer @tkoeppe @burblebee @JohelEGP @Mick235711