Skip to content

P1659R3 starts_with and ends_with #4674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021
Merged

P1659R3 starts_with and ends_with #4674

merged 1 commit into from
Jun 16, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-06 milestone Jun 9, 2021
@jensmaurer jensmaurer force-pushed the motions-2021-06-lwg-10 branch from d27d9f7 to a2f0bc4 Compare June 11, 2021 10:55
@jensmaurer
Copy link
Member Author

@JohelEGP , thanks, fixed.

@tkoeppe tkoeppe force-pushed the motions-2021-06-lwg-10 branch from a2f0bc4 to 9418a95 Compare June 16, 2021 16:25
Comment on lines +4261 to +4265
template<@\libconcept{input_range}@ R1, @\libconcept{input_range}@ R2, class Pred = ranges::equal_to, class Proj1 = identity,
class Proj2 = identity>
requires @\libconcept{indirectly_comparable}@<iterator_t<R1>, iterator_t<R2>, Pred, Proj1, Proj2>
constexpr bool ranges::starts_with(R1&& r1, R2&& r2, Pred pred = {},
Proj1 proj1 = {}, Proj2 proj2 = {});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely: I'm not sure why this second overload doesn't have a specification, but that's what's in the paper. Please let me know if anything is missing here (or if this is covered by some blanket wording elsewhere).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The range overloads map to the first/last overloads per [algorithms.requirements] p14.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, thanks!

@tkoeppe tkoeppe merged commit b686c6e into master Jun 16, 2021
@jensmaurer jensmaurer deleted the motions-2021-06-lwg-10 branch October 21, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2021-06 LWG Motion 10] P1659R3 starts_with and ends_with P1659 starts_with and ends_with
3 participants