Skip to content

P0318R1 unwrap_ref_decay and unwrap_reference #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 26, 2018
Merged

Conversation

jensmaurer
Copy link
Member

Add the type trait as subclause [refwrap.unwrapref],
instead of as a sibling of [refwrap].
Rephrase the wording to avoid referencing X before it
is introduced.
Do not refer to 'equals' as referring to types.

Fixes #2419.

@jensmaurer jensmaurer added this to the post-2018-11 milestone Nov 15, 2018
@jensmaurer
Copy link
Member Author

jensmaurer commented Nov 15, 2018

Open issue: [refwrap.unwrapref] might need a cross-reference to the definition of "transformation type traits", called Cpp17TransformationTrait, in [meta.rqmts]. @zygoloid, @tkoeppe, your view?

@cpplearner
Copy link
Contributor

These declarations use V1, V2, or VTypes. Should they be changed?

constexpr pair<V1, V2> make_pair(T1&& x, T2&& y);

constexpr tuple<VTypes...> make_tuple(TTypes&&...);

constexpr tuple<VTypes...> make_tuple(TTypes&&... t);

@CaseyCarter
Copy link
Contributor

These declarations use V1, V2, or VTypes. Should they be changed?

Corrected in #2490.

@jensmaurer
Copy link
Member Author

@cpplearner: Yes, we should not use (now undefined) variables. Fixed.

Add the type trait as subclause [refwrap.unwrapref],
instead of as a sibling of [refwrap].
Rephrase the wording to avoid referencing X before it
is introduced.
Do not refer to 'equals' as referring to types.
by inlining unwrap_ref_decay_t into its point of use.
@zygoloid zygoloid force-pushed the motions-2018-11-lwg-13 branch from 085b3f0 to 9232666 Compare November 26, 2018 03:17
@zygoloid zygoloid merged commit 958f4ef into master Nov 26, 2018
@jensmaurer jensmaurer deleted the motions-2018-11-lwg-13 branch October 19, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants