Skip to content

[diff.mods.to.definitions] Add entry for 'nullptr_t in stddef.h' #1056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 17, 2016

Conversation

tkoeppe
Copy link
Contributor

@tkoeppe tkoeppe commented Nov 16, 2016

No description provided.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 16, 2016

Preview:

image

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 16, 2016

Updated:

image

@@ -2295,6 +2295,13 @@

Subclause \ref{cwchar.syn} describes the changes.

\pnum
Headers \tcode{<cstddef>}~(\ref{cstddef.syn})\indexlibrary{\idxhdr{cstddef}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest only mentioning <cstddef> here; the other clauses herein don't mention the corresponding <stddef.h>. If we want to draw attention to this, perhaps D.4 would be the place to do it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, PTAL.

@sigfpe
Copy link

sigfpe commented Nov 16, 2016

Agreed. I don't think that change is editorial.
-------- Original message --------From: Richard Smith [email protected] Date: 11/16/16 2:22 PM (GMT-08:00) To: cplusplus/draft [email protected] Subject: Re: [cplusplus/draft] [diff.mods.to.definitions] Add entry for
  'nullptr_t in stddef.h' (#1056)
@zygoloid commented on this pull request.

In source/compatibility.tex:

@@ -2295,6 +2295,13 @@

Subclause \ref{cwchar.syn} describes the changes.

+\pnum
+Headers \tcode{}~(\ref{cstddef.syn})\indexlibrary{\idxhdr{cstddef}}

I would suggest only mentioning here; the other clauses herein don't mention the corresponding <stddef.h>. If we want to draw attention to this, perhaps D.4 would be the place to do it.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/cplusplus/draft","title":"cplusplus/draft","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/cplusplus/draft"}},"updates":{"snippets":[{"icon":"PERSON","message":"@zygoloid commented on #1056"}],"action":{"name":"View Pull Request","url":"https://github.com/cplusplus/draft/pull/1056#pullrequestreview-8922366"}}}

@tkoeppe tkoeppe force-pushed the newc branch 2 times, most recently from fc6fde8 to 9f96a62 Compare November 17, 2016 14:18
@tkoeppe tkoeppe force-pushed the master branch 2 times, most recently from d2a10b4 to c1f9b30 Compare November 17, 2016 14:36
@zygoloid zygoloid merged commit 6233e94 into cplusplus:master Nov 17, 2016
@tkoeppe tkoeppe deleted the newc branch November 17, 2016 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants