Handle PDB location when project build externally #1354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed but not provided. PDB file usually is located next to the module file in the same directory.
|
|
|
Tests are broken in some legs can you take a look? |
|
It is due to mixed paths (windows + linux). The tests for linux and ios will need to be skipped or the other compiled dll added to Test Assets. What do you prefer? |
|
I think it's enough to skip, update is file system based and should be enough test on one |
|
I found the way to update solution to not limit potential cross-platform usage. I reused previously computed pdb name. |
mklemarczyk
force-pushed
the
feature/DiscoveryOfPdbFileForExternalBuild
branch
from
022e823 to
078a933
Compare
… Path does not handle environment change into account. Meaning that when moved from Windows to Unix, the Path class does not understand the file path anymore.
mklemarczyk
force-pushed
the
feature/DiscoveryOfPdbFileForExternalBuild
branch
from
078a933 to
b1f55b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is to handle discovery of PDB files for project build externally (Cloud build, Cluster build, Remote build).
Therefore the path mostly will not match with original build location and the PDB file should be detected by looking in the same directory as module file.
The issue is reproduced with new unit test.
The PR solves the issue #1353