refactor(config): remove evmAppOptions entirely

CHANGELOG.md

@@ -64,6 +64,8 @@
 - [\#477](https://github.com/cosmos/evm/pull/477) Refactor precompile constructors to accept keeper interfaces instead of concrete implementations, breaking the existing `NewPrecompile` function signatures.
 - [\#594](https://github.com/cosmos/evm/pull/594) Remove all usage of x/params
 - [\#577](https://github.com/cosmos/evm/pull/577) Changed the way to create a stateful precompile based on the cmn.Precompile, change `NewPrecompile` to not return error.
+- [\#661](https://github.com/cosmos/evm/pull/661) Removes evmAppOptions from the repository and moves initialization to genesis. Chains must now have a display and denom metadata set for the defined EVM denom in the bank module's metadata.
+
 
 ## v0.4.1
 

ante/evm/fee_checker_test.go

@@ -35,9 +35,24 @@ func TestSDKTxFeeChecker(t *testing.T) {
 	//      without extension option
 	//      london hardfork enableness
 	chainID := uint64(config.EighteenDecimalsChainID)
-	encodingConfig := encoding.MakeConfig(chainID)
-	err := config.EvmAppOptions(chainID)
+	encodingConfig := encoding.MakeConfig(chainID) //nolint:staticcheck // this is used
+
+	configurator := evmtypes.NewEVMConfigurator()
+	configurator.ResetTestConfig()
+	// set global chain config
+	ethCfg := evmtypes.DefaultChainConfig(chainID)
+	if err := evmtypes.SetChainConfig(ethCfg); err != nil {
+		panic(err)
+	}
+	err := configurator.
+		WithExtendedEips(evmtypes.DefaultCosmosEVMActivators).
+		// NOTE: we're using the 18 decimals default for the example chain
+		WithEVMCoinInfo(config.ChainsCoinInfo[chainID]).
+		Configure()
 	require.NoError(t, err)
+	if err != nil {
+		panic(err)
+	}
 
 	evmDenom := evmtypes.GetEVMCoinDenom()
 	minGasPrices := sdk.NewDecCoins(sdk.NewDecCoin(evmDenom, math.NewInt(10)))

ante/evm/mono_decorator.go

@@ -111,8 +111,11 @@ func (md MonoDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, ne
 		Time:       uint64(ctx.BlockTime().Unix()), //nolint:gosec
 		Difficulty: big.NewInt(0),
 	}
+
+	chainConfig := evmtypes.GetEthChainConfig()
+
 	if err := txpool.ValidateTransaction(ethTx, &header, decUtils.Signer, &txpool.ValidationOptions{
-		Config:  evmtypes.GetEthChainConfig(),
+		Config:  chainConfig,
 		Accept:  AcceptedTxType,
 		MaxSize: math.MaxUint64, // tx size is checked in cometbft
 		MinTip:  new(big.Int),

ante/evm/mono_decorator_test.go

@@ -147,7 +147,6 @@ func toMsgSlice(msgs []*evmsdktypes.MsgEthereumTx) []sdk.Msg {
 
 func TestMonoDecorator(t *testing.T) {
 	chainID := uint64(config.EighteenDecimalsChainID)
-	require.NoError(t, config.EvmAppOptions(chainID))
 	cfg := encoding.MakeConfig(chainID)
 
 	testCases := []struct {
@@ -197,6 +196,23 @@ func TestMonoDecorator(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
+			configurator := evmsdktypes.NewEVMConfigurator()
+			configurator.ResetTestConfig()
+			chainConfig := evmsdktypes.DefaultChainConfig(evmsdktypes.DefaultEVMChainID)
+			err := evmsdktypes.SetChainConfig(chainConfig)
+			require.NoError(t, err)
+			coinInfo := evmsdktypes.EvmCoinInfo{
+				Denom:         evmsdktypes.DefaultEVMExtendedDenom,
+				ExtendedDenom: evmsdktypes.DefaultEVMExtendedDenom,
+				DisplayDenom:  evmsdktypes.DefaultEVMDisplayDenom,
+				Decimals:      18,
+			}
+			err = configurator.
+				WithExtendedEips(evmsdktypes.DefaultCosmosEVMActivators).
+				// NOTE: we're using the 18 decimals default for the example chain
+				WithEVMCoinInfo(coinInfo).
+				Configure()
+			require.NoError(t, err)
 			privKey, _ := ethsecp256k1.GenerateKey()
 			keeper, cosmosAddr := setupFundedKeeper(t, privKey)
 			accountKeeper := MockAccountKeeper{FundedAddr: cosmosAddr}