This repository was archived by the owner on Jul 11, 2018. It is now read-only.
Fixed failed parsing on nullable options #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 31, 2015 16:44
Added unit test for nullable types
When shortName is specified, longName cannot be used. This appears to be by design so that unit test has been updated to reflect.
Added unit test for sequences with Min = 0
|
I only meant for 851779a to be in this PR. Shoulda made a branch for the fix. Sorry, first time trying this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enum.Parse and Convert.Change type can't convert directly from string to a nullable type so I added a type conversion to the underlying type before parsing/converting takes place. Also added a unit test for nullable types as options.