Fix panic in lite #760
Merged
Fix panic in lite #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rndstr
approved these changes
Mar 21, 2018
pkg/ingester/client/client.go
Outdated
Contributor
There was a problem hiding this comment.
this could use a comment as to why we need to do this
lite uses both ingester.Config and distributor.Config. Both of them has IngesterClientConfig, so calling RegisterFlags on them triggers panic. This fix ignores second call to RegisterFlags on IngesterClientConfig and then populates it manually. Was broken in 6191d41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lite uses both ingester.Config and distributor.Config. Both of them has IngesterClientConfig, so calling RegisterFlags on them triggers panic.
This fix ignores second call to RegisterFlags on IngesterClientConfig and then populates it manually
Was broken in 6191d41