Skip to content

Conversation

@bboreham
Copy link
Contributor

Log-like API to generate events, plus simple implementation dumping to stderr.

Only wired into ingester for now.

You would turn this on via command-line parameter -event.sample-rate=1000, for example, then one in every 1000 "events" will appear in your log file, and you can extract them for analysis in your favourite tool.

Log-like API to generate events, plus simple implementation dumping to
stderr.

Only wired into ingester for now.
@bboreham bboreham added the type/observability To help know what is going on inside Cortex label Mar 16, 2018
@csmarchbanks
Copy link
Contributor

Couple questions: Why this instead of logging on a jaeger trace?

Would it be worthwhile to have the event log function look for a jaeger span and add it there as well?

@bboreham
Copy link
Contributor Author

Mostly because I have no idea how to use Jaeger to do statistical analysis across multiple events. If you can point me at some explanation that'd be great.

Looking for a span is a good idea in the general case, but these particular ones are timer-based - currently there is no parent span, and if we added one it would just collect a random set of events on each tick.

@bboreham
Copy link
Contributor Author

Correction, adding to the flush queue is timer based; pulling from the flush queue is when-available. There's no structure, which is where I typically see the real power of Jaeger.

Copy link
Contributor

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@bboreham bboreham merged commit 03b4538 into master Mar 19, 2018
@bboreham bboreham deleted the log-events branch March 19, 2018 10:19
@bboreham bboreham mentioned this pull request Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/observability To help know what is going on inside Cortex

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants