Move AWS storage implementations into pkg/chunk/aws #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
force-pushed
the
aws-chunk-store
branch
4 times, most recently
from
272d23b to
3b47305
Compare
Contributor
|
👍 Especially on the dep upgrade - I was a hair's breadth from doing this yesterday! At a glance, this makes chunk code far less confusing to navigate. It all built cleanly for me, and I rolled the querier out to our staging environment as a quick smoke-test - worked fine. Thanks for this! |
Contributor
Author
|
New dep is much faster too, massive win. Thanks! |
Contributor
|
Couldn't get to this PR this week. @bboreham or myself will get to it next
week.
…On Wed, 14 Feb 2018 at 16:50 Tom Wilkie ***@***.***> wrote:
New dep is much faster too, massive win.
Thanks!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#705 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAHq6ozhog0M9FHuPvMHULPRXC5UkQzCks5tUw65gaJpZM4SFVL4>
.
|
This promotes decoupling and allows us to start reusing some the more generic chunk storage tests against the other backends. Also: - Set up test fixtures for the BigTable backend. - Honor context cancellation in bigtable.GetChunks. - Ensure test only asks for given chunks once per batch. - Some renaming in the AWS pkg to remove the stutter.
tomwilkie
force-pushed
the
aws-chunk-store
branch
from
3b47305 to
6017c8e
Compare
tomwilkie
force-pushed
the
aws-chunk-store
branch
from
46c3c8e to
0e487d2
Compare
Contributor
Author
|
@bboreham this has been rebase now. |
bboreham
approved these changes
Feb 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move AWS-related code into chunk/aws package.
This promotes decoupling and allows us to start reusing some the more generic chunk storage tests against the other backends.
Also: