Skip to content

Revert "New ruler endpoints" #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2018
Merged

Revert "New ruler endpoints" #648

merged 1 commit into from
Jan 11, 2018

Conversation

@jml
Copy link
Contributor

@jml jml commented Jan 11, 2018

Reverts #620

ts=2018-01-11T16:13:12.890380004Z caller=log.go:108 level=info msg="ruler up and running"
ts=2018-01-11T16:13:12.929348187Z caller=log.go:108 level=warn msg="scheduler: configs server poll failed" err="dial tcp: lookup configs-db.weave.local on 10.0.0.10:53: no such host"
ts=2018-01-11T16:13:12.929426996Z caller=log.go:108 level=warn msg="scheduler: error fetching all configurations, backing off" err="dial tcp: lookup configs-db.weave.local on 10.0.0.10:53: no such host"

Repeats.

@jml jml requested a review from dlespiau January 11, 2018 16:36
@jml jml merged commit 860d2fb into master Jan 11, 2018
jml added a commit that referenced this pull request Jan 11, 2018
@jml
Revert "Revert "New ruler endpoints (#620)" (#648)"
cb84080 
This reverts commit 860d2fb.
jml added a commit that referenced this pull request Jan 12, 2018
@jml
New CAS endpoints for ruler configs on ruler itself (#649)
a45e98d 
* Revert "Revert "New ruler endpoints (#620)" (#648)"

This reverts commit 860d2fb.

* Use DB only if Configs API *not* provided

Works around the fact that `database.uri` has a default value, so we cannot
detect whether the user has explicitly asked for a database or not.
@tomwilkie tomwilkie deleted the revert-620-619-new-ruler-endpoints branch August 29, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dlespiau dlespiau dlespiau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jml @dlespiau