Add a flag to enable TSDB memorry snapshot on shutdown #5011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
2 times, most recently
from
9a9d626 to
978215a
Compare
yeya24
reviewed
Dec 2, 2022
yeya24
reviewed
Dec 2, 2022
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
2 times, most recently
from
dc073d5 to
2b28bd9
Compare
alanprot
reviewed
Dec 3, 2022
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
from
2b28bd9 to
46136f4
Compare
yeya24
reviewed
Dec 3, 2022
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
from
46136f4 to
df1fb7c
Compare
Contributor
|
@alanprot @friedrichg Please share your thoughts about this change. Should we make it a global configuration or a per tenant configuration? The criteria of when should we make a config per tenant is somewhat not very clear to me. But since some other TSDB configurations are also global so this one is probably fine to be global, too. |
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
from
df1fb7c to
6203538
Compare
Signed-off-by: wangguoliang <[email protected]>
wgliang
force-pushed
the
feature/enable-tsdb-memory-snapshot-on-shutdown
branch
from
6203538 to
da52a1f
Compare
Contributor
Author
|
The pr has been updated, are there any other comments？ |
friedrichg
approved these changes
Dec 6, 2022
Member
friedrichg
left a comment
friedrichg
left a comment
There was a problem hiding this comment.
Thanks for the PR and addressing the feedback!
yeya24
approved these changes
Dec 6, 2022
Contributor
yeya24
left a comment
yeya24
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wangguoliang [email protected]
What this PR does:
Add a flag to enable TSDB memorry snapshot on shutdown.
FYI:https://ganeshvernekar.com/blog/prometheus-tsdb-snapshot-on-shutdown/#faster-restarts
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]