Skip to content

Upgrde build docker engine to latest version #4961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Upgrde build docker engine to latest version #4961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/scripts/install-docker.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

set -x
VER="18.06.3-ce"
VER="20.10.19"
curl -L -o /tmp/docker-$VER.tgz https://download.docker.com/linux/static/stable/x86_64/docker-$VER.tgz
tar -xz -C /tmp -f /tmp/docker-$VER.tgz
mv /tmp/docker/* /usr/bin
5 changes: 4 additions & 1 deletion integration/e2e/service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -523,7 +523,10 @@ func (s *HTTPService) Metrics() (_ string, err error) {
localPort := s.networkPortsContainerToLocal[s.httpPort]

// Fetch metrics.
res, err := GetRequest(fmt.Sprintf("http://localhost:%d/metrics", localPort))
// We use IPv4 ports from Dokcer for e2e tests, so lt's use 127.0.0.1 to force IPv4; localhost may map to IPv6.
// It's possible that same port number map to IPv4 for serviceA and IPv6 for servieB, so using localhost makes
// tests flaky because you connect to serviceB while you want to connec to serviceA.
res, err := GetRequest(fmt.Sprintf("http://127.0.0.1:%d/metrics", localPort))
if err != nil {
return "", err
}
Expand Down