Update proposal for timeseries partitioning in compactor #4882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osal Signed-off-by: Alex Le <[email protected]>
Contributor
|
@alexqyle opps, lint failed. It's usually due to trailing space in the markdwon file :-) |
alvinlin123
reviewed
Sep 28, 2022
alvinlin123
reviewed
Sep 28, 2022
alvinlin123
reviewed
Sep 28, 2022
Contributor
alvinlin123
left a comment
alvinlin123
left a comment
There was a problem hiding this comment.
First of all, thank you so much for adding these details.
But, I think the Compaction Workflow section contains too much implementation details, which is not suitable in a proposal.
Compaction Partitioning Examples section is good to keep.
alvinlin123
reviewed
Sep 28, 2022
Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Sep 30, 2022
…d some wording Signed-off-by: Alex Le <[email protected]>
yeya24
reviewed
Sep 30, 2022
Signed-off-by: Alex Le <[email protected]>
Signed-off-by: Alex Le <[email protected]>
alvinlin123
reviewed
Oct 1, 2022
alvinlin123
reviewed
Oct 1, 2022
alvinlin123
reviewed
Oct 1, 2022
alvinlin123
approved these changes
Oct 1, 2022
Signed-off-by: Alex Le <[email protected]>
…mpletion logic in compactor Signed-off-by: Alex Le <[email protected]>
alanprot
approved these changes
Oct 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Added compaction and clean up workflow to partitioning compactor proposal (#4843)
Which issue(s) this PR fixes:
Design to fix #4705
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]