Refactor: move the Purger to different directory
#4861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ilangofman <[email protected]>
ilangofman
force-pushed
the
move_purger_dir
branch
from
8797942 to
785102c
Compare
harry671003
reviewed
Sep 14, 2022
Signed-off-by: ilangofman <[email protected]>
alanprot
approved these changes
Sep 20, 2022
Member
|
Make sense to me |
friedrichg
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Now that chunk storage has been removed and all the series deletion functionality was for chunk storage, I think it is more fitting for the
Purgercode to be inside a different directory other thanpkg/chunk/. I moved all the purger filespkg/storage/. If there is a different directory that might be more fitting, please let me know.Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]