Skip to content

Conversation

@siggy
Copy link
Contributor

@siggy siggy commented Dec 9, 2021

Rearrange CHANGELOG.md to conform to instructions in
pull_request_template.md.

Also add a - to a CLI flag to conform to instructions in
design-patterns-and-conventions.md.

Signed-off-by: Andrew Seigner [email protected]

What this PR does:

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Rearrange `CHANGELOG.md` to conform to instructions in
`pull_request_template.md`.

Also add a `-` to a CLI flag to conform to instructions in
`design-patterns-and-conventions.md`.

Signed-off-by: Andrew Seigner <[email protected]>
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bboreham bboreham merged commit 4474da8 into cortexproject:master Dec 10, 2021
alvinlin123 pushed a commit to ac1214/cortex that referenced this pull request Jan 14, 2022
Rearrange `CHANGELOG.md` to conform to instructions in
`pull_request_template.md`.

Also add a `-` to a CLI flag to conform to instructions in
`design-patterns-and-conventions.md`.

Signed-off-by: Andrew Seigner <[email protected]>
Signed-off-by: Alvin Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants