fix incomplete and confusing website cover title #4497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added missing "storage for" in the website cover title. - without these words, it feels Cortex is a replacement for Prometheus. Signed-off-by: Ranganath Kini <[email protected]>
Signed-off-by: Ranganath Kini <[email protected]>
pracucci
reviewed
Sep 29, 2021
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Thanks for the fix! I think you need to fix it in website/config.toml and then run make web-build to build the website.
pracucci
reviewed
Sep 29, 2021
Co-authored-by: Marco Pracucci <[email protected]> Signed-off-by: Ranganath Kini <[email protected]>
Signed-off-by: Ranganath Kini <[email protected]>
bboreham
approved these changes
Oct 1, 2021
srijan55
pushed a commit
to srijan55/cortex
that referenced
this pull request
Nov 26, 2021
- added missing "storage for" in the website cover title. - without these words, it feels Cortex is a replacement for Prometheus. Signed-off-by: Ranganath Kini <[email protected]> Signed-off-by: Manish Kumar Gupta <[email protected]>
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
- added missing "storage for" in the website cover title. - without these words, it feels Cortex is a replacement for Prometheus. Signed-off-by: Ranganath Kini <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fixes website code to add "storage for" words in cover title to convey what Cortex is.
Which issue(s) this PR fixes:
Fixes #4496
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]