point out that disabling shard-by-all-labels has down-sides #4452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mauro Stettler <[email protected]>
Contributor
|
Thanks for this. I wonder if we should try to collect together all notes on this setting in one place; currently there is a section at Then you could put a reference from the zone-replication doc to the one place where we describe the setting. |
Contributor
Author
|
Good idea, I updated it accordingly, PTAL |
bboreham
approved these changes
Sep 1, 2021
Contributor
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
lgtm; see warning about DCO
bboreham
changed the title
Contributor
Author
sorry, that always gets me |
Signed-off-by: Mauro Stettler <[email protected]>
pstibrany
approved these changes
Sep 2, 2021
alvinlin123
pushed a commit
to ac1214/cortex
that referenced
this pull request
Jan 14, 2022
…oject#4452) Signed-off-by: Mauro Stettler <[email protected]> Signed-off-by: Alvin Lin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we might want to add that notice to the docs, because I have seen a real world user who disabled
-distributor.shard-by-all-labelsdue to this paragraph in the docs without being aware that this may lead to other issues.