Migrate CircleCI workflows to GitHub Actions (2/3) #3341
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -x | ||
| VER="17.03.0-ce" | ||
| curl -L -o /tmp/docker-$VER.tgz https://download.docker.com/linux/static/stable/x86_64/docker-$VER.tgz | ||
| tar -xz -C /tmp -f /tmp/docker-$VER.tgz | ||
| mv /tmp/docker/* /usr/bin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,6 +5,7 @@ on: | |
| tags: | ||
| - v[0-9]+.[0-9]+.[0-9]+** # Tag filters not as strict due to different regex system on Github Actions | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-latest | ||
|
|
@@ -13,6 +14,8 @@ jobs: | |
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v2 | ||
| # Commands in the Makefile are hardcoded with an assumed file structure of the CI container | ||
| # Symlink ensures paths specified in previous commands don’t break | ||
| - name: Sym Link Expected Path to Workspace | ||
| run: | | ||
| mkdir -p /go/src/github.com/cortexproject/cortex | ||
|
|
@@ -57,12 +60,7 @@ jobs: | |
| - name: Checkout Repo | ||
| uses: actions/checkout@v2 | ||
| - name: Install Docker Client | ||
| run: ./.github/workflows/scripts/install-docker.sh | ||
| - name: Sym Link Expected Path to Workspace | ||
| run: | | ||
| mkdir -p /go/src/github.com/cortexproject/cortex | ||
|
|
@@ -80,10 +78,89 @@ jobs: | |
| mkdir /tmp/images | ||
| ln -s /tmp/images ./docker-images | ||
| make BUILD_IN_CONTAINER=false save-images | ||
| - name: Create Docker Images Archive | ||
| run: tar -cvf images.tar /tmp/images | ||
| - name: Upload Docker Images Artifact | ||
| uses: actions/upload-artifact@v2 | ||
| with: | ||
| name: Docker Images | ||
| path: ./images.tar | ||
|
|
||
| integration: | ||
| needs: build | ||
| runs-on: ubuntu-16.04 | ||
| steps: | ||
| - name: Upgrade golang | ||
| run: | | ||
| cd /tmp | ||
| wget https://dl.google.com/go/go1.14.9.linux-amd64.tar.gz | ||
| tar -zxvf go1.14.9.linux-amd64.tar.gz | ||
| sudo rm -fr /usr/local/go | ||
| sudo mv /tmp/go /usr/local/go | ||
| cd - | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v2 | ||
| - name: Install Docker Client | ||
| run: sudo ./.github/workflows/scripts/install-docker.sh | ||
| - name: Sym Link Expected Path to Workspace | ||
| run: | | ||
| sudo mkdir -p /go/src/github.com/cortexproject/cortex | ||
| sudo ln -s $GITHUB_WORKSPACE/* /go/src/github.com/cortexproject/cortex | ||
| - name: Download Docker Images Artifacts | ||
| uses: actions/download-artifact@v2 | ||
| with: | ||
| name: Docker Images | ||
| - name: Extract Docker Images Archive | ||
| run: tar -xvf images.tar -C / | ||
| - name: Load Docker Images | ||
| run: | | ||
| ln -s /tmp/images ./docker-images | ||
| make BUILD_IN_CONTAINER=false load-images | ||
| - name: Preload Images | ||
| # We download docker images used by integration tests so that all images are available | ||
| # locally and the download time doesn't account in the test execution time, which is subject | ||
| # to a timeout | ||
| run: | | ||
| docker pull minio/minio:RELEASE.2019-12-30T05-45-39Z | ||
| docker pull amazon/dynamodb-local:1.11.477 | ||
| docker pull consul:0.9 | ||
| docker pull gcr.io/etcd-development/etcd:v3.4.7 | ||
| docker pull quay.io/cortexproject/cortex:v1.0.0 | ||
| docker pull quay.io/cortexproject/cortex:v1.1.0 | ||
pracucci marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| docker pull quay.io/cortexproject/cortex:v1.2.0 | ||
| docker pull quay.io/cortexproject/cortex:v1.3.0 | ||
| docker pull quay.io/cortexproject/cortex:v1.4.0 | ||
| docker pull shopify/bigtable-emulator:0.1.0 | ||
| docker pull rinscy/cassandra:3.11.0 | ||
| docker pull memcached:1.6.1 | ||
| docker pull bouncestorage/swift-aio:55ba4331 | ||
| - name: Integration Tests | ||
| run: | | ||
| export CORTEX_IMAGE_PREFIX="${IMAGE_PREFIX:-quay.io/cortexproject/}" | ||
| export CORTEX_IMAGE="${CORTEX_IMAGE_PREFIX}cortex:${TAG:-$(./tools/image-tag)}" | ||
| export CORTEX_CHECKOUT_DIR="/go/src/github.com/cortexproject/cortex" | ||
| echo "Running integration tests with image: $CORTEX_IMAGE" | ||
| go test -tags=requires_docker -timeout 1800s -v -count=1 ./integration/... | ||
| env: | ||
| IMAGE_PREFIX: ${{ secrets.IMAGE_PREFIX }} | ||
|
Contributor
There was a problem hiding this comment. This secret will need to be added in the forked repo if one wants to change the image_prefix |
||
| TAG: ${{ github.event.push.tag_name }} | ||
|
|
||
| integration-configs-db: | ||
| needs: build | ||
| runs-on: ubuntu-16.04 | ||
| steps: | ||
| - name: Checkout Repo | ||
| uses: actions/checkout@v2 | ||
| - name: Install Docker Client | ||
| run: sudo ./.github/workflows/scripts/install-docker.sh | ||
| - name: Download Docker Images Artifact | ||
| uses: actions/download-artifact@v2 | ||
| with: | ||
| name: Docker Images | ||
| - name: Extract Docker Images Archive | ||
| run: tar -xvf images.tar -C / | ||
| - name: Run Integration Configs Tests | ||
| run: | | ||
| touch build-image/.uptodate | ||
| MIGRATIONS_DIR=$(pwd)/cmd/cortex/migrations | ||
| make BUILD_IMAGE=quay.io/cortexproject/build-image:upgrade-build-image-debian-491e60715-WIP TTY='' configs-integration-test | ||
|
Contributor
There was a problem hiding this comment. Could you add a comment to explain why we need
Contributor
There was a problem hiding this comment. The default runners in GitHub Actions don't support TTY :( actions/runner#241 and a GitHub member responded saying its fairly low prio in their backlog. This is what happens when we remove
However, there is a workaround we can do if you'd like it back: https://man7.org/linux/man-pages/man1/script.1.html steps:
- uses: actions/checkout@v1
run: |
touch build-image/.uptodate
MIGRATIONS_DIR=$(pwd)/cmd/cortex/migrations
script -e -c "make BUILD_IMAGE=quay.io/cortexproject/build-image:upgrade-build-image-debian-491e60715-WIP configs-integration-test"This works and enables the command to run with TTY but this seemed kind of hacky to me so I left it as Would you like us to change the line to use
Contributor
There was a problem hiding this comment. I think comment explaining why
Contributor
There was a problem hiding this comment.
Let's just add a comment, but not a block so you can do it in a following PR. |
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Linking the directory instead of the contents of the folder did not work when we tested it.