Skip to content

Conversation

@pracucci
Copy link
Contributor

@pracucci pracucci commented Oct 12, 2020

What this PR does:
The PR #3302 made me realise the build-image is built on top of an old version of Debian. In this PR I'm attempting to upgrade to Debian buster.

Protobuf compiled sources have changed because libprotobuf-dev (installed via apt-get) upgraded from 3.0.0 to 3.6.1. To my understanding, this shouldn't be an issue for us.

I manually tested building the website and it looks good.

/cc @AzfaarQureshi

Which issue(s) this PR fixes:
N/A

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this build image fixes old Git version problem .There is a mention in .github/README.md about this that should be updated.

@pracucci pracucci force-pushed the upgrade-build-image-debian branch from d94de23 to 9dbc6ae Compare October 12, 2020 12:03
@pull-request-size pull-request-size bot added size/M and removed size/S labels Oct 12, 2020
@pracucci pracucci merged commit 7a66f21 into cortexproject:master Oct 12, 2020
@pracucci pracucci deleted the upgrade-build-image-debian branch October 12, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants