Update Thanos to latest master. #3271
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
Signed-off-by: Peter Štibraný <[email protected]>
pracucci
reviewed
Oct 6, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
@pstibrany This Thanos fix thanos-io/thanos#3279 is a blocker for the upgrade. Could you keep it monitored, please?
Contributor
Author
From what I understand, that only affects Receive part of Thanos, that we don't use. |
3 tasks
Contributor
|
@pstibrany I'm going to close this PR in favour of #3363. If turns out #3363 can't be merged, we can reopen this PR anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR updates Thanos dependency to latest master. Main reason for update is to get thanos-io/thanos#3261 in.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]