fix a flaky test in purger #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sandeep Sukhani <[email protected]>
pracucci
approved these changes
Jul 7, 2020
Contributor
pracucci
left a comment
pracucci
left a comment
There was a problem hiding this comment.
Thanks for the fix! LGTM
|
|
||
| // start loop to process requests | ||
| // stop the existing purger | ||
| require.NoError(t, services.StopAndAwaitTerminated(context.Background(), purger)) |
Contributor
There was a problem hiding this comment.
At the beginning of the test there's a deferred call to purger.StopAsync(). Given we're now terminating it here, I believe that call should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
In
TestPurger_Metricstest I was starting the purger service here after pulling the delete requests for processing here which usually should never happen because we always start the service first. This was done to capture an expected metric value.This was causing Purger to work in an unexpected way causing it to fail the test sometimes. I have changed the test to stop existing purger and create a new one to start the service for delete request processing.
Which issue(s) this PR fixes:
Fixes #2840
Checklist