Micro optimization in newBlockQuerierSeries() #2633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marco Pracucci <[email protected]>
pstibrany
approved these changes
May 26, 2020
Contributor
pstibrany
left a comment
pstibrany
left a comment
There was a problem hiding this comment.
LGTM (failing test can be removed, as it's not real-case scenario, as discussed at https://cloud-native.slack.com/archives/CL25937SP/p1590491672334400)
Signed-off-by: Marco Pracucci <[email protected]>
Contributor
Author
I double checked and looks safe. I've also opened a 1-line PR in Thanos to document it thanos-io/thanos#2662 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Since #2599 we don't need to use labels builder anymore. An unsafe conversion should just be fine.
Which issue(s) this PR fixes:
N/A
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]